Add tests for ProperContains and ProperIn#40
Closed
antvaset wants to merge 1 commit intocqframework:mainfrom
antvaset:propercontains-properin-tests
Closed
Add tests for ProperContains and ProperIn#40antvaset wants to merge 1 commit intocqframework:mainfrom antvaset:propercontains-properin-tests
antvaset wants to merge 1 commit intocqframework:mainfrom
antvaset:propercontains-properin-tests
Conversation
This was referenced Jul 31, 2024
brynrhodes
approved these changes
Jul 31, 2024
Contributor
Author
|
This PR cannot be reopened, so I had to create a new one - see #48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more tests for
ProperContainsandProperInoperators to cover more edge cases for the list overload.Adjusting 4 existing tests to make it clear and make sure that
ProperContainsNullRightFalseandProperContainsNullRightTruecompile toProperContains(List<T>, T)and thatProperInNullRightFalseandProperInNullRightTruecompile toProperIn(T, List<T>), matching the test name/group. Withoutnull as String, the args could be resolved asList<T>, List<T>and compile toProperIncludes(List<T>, List<T>)andProperIncludedIn(List<T>, List<T>).